Open
Conversation
- Add specific exit codes (0-7, 99) for different failure modes - Improve error messages to distinguish between: - No clipboard image vs conversion failure - Permission denied vs invalid path vs disk errors - Fix memory leak in parseArguments (NSString never released) - Add shell-based integration test suite with 32 tests - Add `make test` target Exit codes: 0: Success 1: Usage error 2: No clipboard image 3: Conversion error 4: Permission denied 5: Invalid path 6: Disk error 7: Stdout error 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Previously, converting GIF images with alpha channels to JPEG would fail silently because JPEG doesn't support transparency. Now, images with alpha channels are composited onto a white background before JPEG conversion, matching the existing PDF rendering behavior. Changes: - Add removeAlphaChannel() helper that composites onto white - Update renderFromBitmap() to handle alpha->JPEG conversion - Add JPEG compression quality (0.9) - Add test for GIF with transparency -> JPEG - Update README to document transparency handling and EXIF limitation 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacks on #28
And tries to resolve what happens when GIF files are the input